Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose animation_clip paths #9392

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Expose animation_clip paths #9392

merged 3 commits into from
Aug 11, 2023

Conversation

jfaz1
Copy link
Contributor

@jfaz1 jfaz1 commented Aug 9, 2023

Need this for a custom AnimationPlayer that I tick in FixedUpdate

Objective

  • Need access to an animation clip's paths from outside the module

Solution

  • Add a getter method to return a reference to paths

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Animation Make things move and change over time labels Aug 9, 2023
tguichaoua
tguichaoua suggested changes Aug 9, 2023
View reviewed changes
crates/bevy_animation/src/lib.rs Outdated Show resolved Hide resolved
@jfaz1 @tguichaoua
Update crates/bevy_animation/src/lib.rs
310d530 
Co-authored-by: Tristan Guichaoua <33934311+tguichaoua@users.noreply.github.com>
@jfaz1 jfaz1 requested a review from tguichaoua August 10, 2023 02:34
tguichaoua
tguichaoua suggested changes Aug 10, 2023
View reviewed changes
crates/bevy_animation/src/lib.rs Outdated Show resolved Hide resolved
@jfaz1 @tguichaoua
Update crates/bevy_animation/src/lib.rs
a4cc360 
Co-authored-by: Tristan Guichaoua <33934311+tguichaoua@users.noreply.github.com>
tguichaoua
tguichaoua approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@tguichaoua tguichaoua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 11, 2023
@mockersf mockersf added this pull request to the merge queue Aug 11, 2023
Merged via the queue into bevyengine:main with commit ad4ec14 Aug 11, 2023
@jfaz1 jfaz1 deleted the animation_paths branch October 18, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tguichaoua tguichaoua tguichaoua approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfaz1 @alice-i-cecile @mockersf @tguichaoua